[FLINK-36473] Wait for metrics before asserting on them #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aplyusnin
approved these changes
Oct 11, 2024
aplyusnin
left a comment
aplyusnin
left a comment
There was a problem hiding this comment.
Hi, I prefer your changes over mine. I will close my pr after your pr is merged
Frawless
approved these changes
Oct 11, 2024
mateczagany
reviewed
Oct 11, 2024
flink-autoscaler/src/test/java/org/apache/flink/autoscaler/RestApiMetricsCollectorTest.java
Outdated
Show resolved
Hide resolved
tomncooper
approved these changes
Oct 11, 2024
Contributor
tomncooper
left a comment
tomncooper
left a comment
There was a problem hiding this comment.
LGTM, just a couple of small questions.
.../src/test/java/org/apache/flink/kubernetes/operator/metrics/KubernetesClientMetricsTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Operator metrics are lazily initialised. This PR addresses race conditions in tests trying to assert metrics.
An alternative to the
Thread.sleepproposed in #891Brief change log
Wait for metrics to be initialised in integration tests.
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
This change is purely a fix to
RestApiMetricsCollectorTest&KubernetesClientMetricsTestDoes this pull request potentially affect one of the following parts:
CustomResourceDescriptors: noDocumentation